check null point before setting auto read #7999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Sep 8, 2020
codelipenghui
approved these changes
Sep 8, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
apache#7919 was forced to be closed. I've opened a new pr to address rebase issue. Pulsar enable throttler to controll the speed of consuming data. But sometimes ctx will be closed while throttler is running in a independent thread. We should check ctx null point before setting auto read. NPE will be thrown if throttler is enabled and ctx is closed. It would be more graceful if we check null before enabling auto read
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
#7919 was forced to be closed. I've opened a new pr to address rebase issue. Pulsar enable throttler to controll the speed of consuming data. But sometimes ctx will be closed while throttler is running in a independent thread. We should check ctx null point before setting auto read. NPE will be thrown if throttler is enabled and ctx is closed. It would be more graceful if we check null before enabling auto read (cherry picked from commit eb1165b)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
apache#7919 was forced to be closed. I've opened a new pr to address rebase issue. Pulsar enable throttler to controll the speed of consuming data. But sometimes ctx will be closed while throttler is running in a independent thread. We should check ctx null point before setting auto read. NPE will be thrown if throttler is enabled and ctx is closed. It would be more graceful if we check null before enabling auto read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7919 was forced to be closed.
I've opened a new pr to address rebase issue.
Pulsar enable throttler to controll the speed of consuming data. But sometimes ctx will be closed while throttler is running in a independent thread. We should check ctx null point before setting auto read.
NPE will be thrown if throttler is enabled and ctx is closed. It would be more graceful if we check null before enabling auto read
@sijie @codelipenghui