Pending ack client implement #8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 16, 2020
| messageIdIterator.remove(); | ||
| } | ||
| transactionIterator.remove(); | ||
| pendingIndividualTransactionBatchIndexAcks.remove(transactionEntry.getKey()); |
There was a problem hiding this comment.
Looks don't need to remove again.
|
/pulsarbot run-failure-checks |
This reverts commit c665fe5.
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
to solve apache#7981 ### Implement #### individual ack with transaction the batch message with transaction just carry their own batchIndex and client must enable batch index ack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to solve #7981
Implement
individual ack with transaction
the batch message with transaction just carry their own batchIndex and client must enable batch index ack.