Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket interface decode URL encoding #8072

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Conversation

315157973
Copy link
Contributor

Fixes #3769

Motivation

Websocket interface does not decode URLencoding

Modifications

add url decode for topic name and subscription

Verifying this change

unit test
AbstractWebSocketHandlerTest#TopicNameUrlEncodingTest

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit c200e9f into apache:master Sep 24, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Oct 3, 2020
Fixes apache#3769

### Motivation
Websocket interface does not decode URLencoding

### Modifications
add url decode for topic name and subscription
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
Fixes #3769

### Motivation
Websocket interface does not decode URLencoding

### Modifications
add url decode for topic name and subscription

(cherry picked from commit c200e9f)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
Fixes apache#3769

### Motivation
Websocket interface does not decode URLencoding

### Modifications
add url decode for topic name and subscription
@315157973 315157973 deleted the decode branch November 28, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket interface does not decode URLencoding
5 participants