Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support subscription dispatch rate on topic level #8087

Merged
merged 1 commit into from
Sep 21, 2020
Merged

support subscription dispatch rate on topic level #8087

merged 1 commit into from
Sep 21, 2020

Conversation

hangc0276
Copy link
Contributor

Modifications

Support set subscription dispatch rate on topic level.
Support get subscription dispatch rate on topic level.
Support remove subscription dispatch rate on topic level.

Verifying this change

This change added tests and can be verified as follows:

  • test set topic subscription dispatch rate
  • test remove subscription dispatch rate
  • test get topic subscription dispatch rate
  • test disabled topic subscription dispatch rate
  • test subscription dispatch rate policy overwritten NamespaceLevel

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes)
  • Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added component/topic-policy type/feature The PR added a new feature or issue requested a new feature labels Sep 21, 2020
@sijie sijie added this to the 2.7.0 milestone Sep 21, 2020
@sijie sijie merged commit 4c508c5 into apache:master Sep 21, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Oct 3, 2020
@hangc0276
support subscription dispatch rate on topic level (apache#8087)
4e36353 
### Modifications
Support set subscription dispatch rate on topic level.
Support get subscription dispatch rate on topic level.
Support remove subscription dispatch rate on topic level.
@codelipenghui codelipenghui mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@hangc0276 hangc0276

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hangc0276 @sijie @codelipenghui