[C++] Fix the unstable unit tests failure #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Sep 27, 2020
This was referenced Sep 27, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Fixes apache#8128 ### Motivation The send callback of `BatchMessageTest` is modifing a global variable which is the count of successfully produced messages. So some tests may failed in multi-thread environment. ### Modifications - Add a `MessageCountSendCallback` class to replace the current send callback function
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
Fixes apache#8128 ### Motivation The send callback of `BatchMessageTest` is modifing a global variable which is the count of successfully produced messages. So some tests may failed in multi-thread environment. ### Modifications - Add a `MessageCountSendCallback` class to replace the current send callback function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8128
Motivation
The send callback of
BatchMessageTestis modifing a global variable which is the count of successfully produced messages. So some tests may failed in multi-thread environment.Modifications
MessageCountSendCallbackclass to replace the current send callback function