[pulsar-broker] Support Disable Replicated Subscriptions #8144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
nkurihar
approved these changes
Sep 30, 2020
codelipenghui
approved these changes
Sep 30, 2020
sijie
approved these changes
Oct 1, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Support disabling "Replicated Subscriptions". ### Motivation apache#8030 "Replicated Subscriptions" is always enabled because enableReplicatedSubscriptions is not used. ### Modifications - When `enableReplicatedSubscriptions` is false, - Brokers don't create `ReplicatedSubscriptionsController`. - Brokers don't check marker messages. - Brokers send `NotAllowedException` to consumers that use `replicateSubscriptionState(true)`
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
Support disabling "Replicated Subscriptions". ### Motivation #8030 "Replicated Subscriptions" is always enabled because enableReplicatedSubscriptions is not used. ### Modifications - When `enableReplicatedSubscriptions` is false, - Brokers don't create `ReplicatedSubscriptionsController`. - Brokers don't check marker messages. - Brokers send `NotAllowedException` to consumers that use `replicateSubscriptionState(true)` (cherry picked from commit b4a2f26)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
Support disabling "Replicated Subscriptions". ### Motivation apache#8030 "Replicated Subscriptions" is always enabled because enableReplicatedSubscriptions is not used. ### Modifications - When `enableReplicatedSubscriptions` is false, - Brokers don't create `ReplicatedSubscriptionsController`. - Brokers don't check marker messages. - Brokers send `NotAllowedException` to consumers that use `replicateSubscriptionState(true)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support disabling "Replicated Subscriptions".
Motivation
#8030
"Replicated Subscriptions" is always enabled because enableReplicatedSubscriptions is not used.
Modifications
enableReplicatedSubscriptionsis false,ReplicatedSubscriptionsController.NotAllowedExceptionto consumers that usereplicateSubscriptionState(true)