Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate updates #8198

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Remove duplicate updates #8198

merged 1 commit into from
Oct 9, 2020

Conversation

315157973
Copy link
Contributor

Motivation

Offload has been updated asynchronously in checkPersistencePolicies() on line 1888, and there is no need to update repeatedly.

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.7.0 milestone Oct 4, 2020
@jiazhai
Copy link
Member

jiazhai commented Oct 4, 2020

@315157973 looks like this is not a dup. it tries to select between ns value and current passedin Policies.
@gaoran10 Would you please help double check this change?

@315157973
Copy link
Contributor Author

@315157973 looks like this is not a dup. it tries to select between ns value and current passedin Policies.
@gaoran10 Would you please help double check this change?

checkPersistencePolicies() will also trigger getManagedLedgerConfig to set the entire config, including offload

@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit aeb5361 into apache:master Oct 9, 2020
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
@315157973 @wolfstudy
Remove duplicate updates (#8198)
a41663c 
### Motivation
Offload has been updated asynchronously in `checkPersistencePolicies()` on line 1888, and there is no need to update repeatedly.

(cherry picked from commit aeb5361)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
@315157973 @huangdx0726
Remove duplicate updates (apache#8198)
fb7aff5 
### Motivation
Offload has been updated asynchronously in `checkPersistencePolicies()` on line 1888, and there is no need to update repeatedly.
@315157973 315157973 deleted the offload branch November 28, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@jiazhai jiazhai Awaiting requested review from jiazhai

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@sijie sijie Awaiting requested review from sijie

Assignees

@315157973 315157973

Labels
release/2.6.2
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@315157973 @jiazhai @codelipenghui