Delete associated ledgers before deleting cluster metadata #8244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
sijie
requested changes
Oct 13, 2020
There was a problem hiding this comment.
@BewareMyPower Can you delete the managed ledger and ledgers using an iterator rather than collecting all the ledgers into a list? If a cluster has a lot of ledgers, it will fill up the memory.
|
@sijie OK |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
sijie
requested changes
Oct 16, 2020
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Show resolved
Hide resolved
eolivelli
requested changes
Oct 17, 2020
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Show resolved
Hide resolved
eolivelli
reviewed
Oct 17, 2020
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
|
Now all checks have passed, PTAL again, @sijie @eolivelli |
eolivelli
requested changes
Oct 17, 2020
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Show resolved
Hide resolved
eolivelli
requested changes
Oct 17, 2020
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Show resolved
Hide resolved
3 tasks
sijie
requested changes
Oct 21, 2020
There was a problem hiding this comment.
@BewareMyPower Can you please add unit tests and integration tests for this tool?
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
I've added an integration test, PTAL, @sijie |
BewareMyPower
changed the title
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
### Motivation #8169 introduced a command tool to delete a cluster's metadata from ZK. This PR intends to delete the cluster's ledgers from BK. ### Modifications - Retrieve ledger ids from related ZK nodes - Add an optional argument to specify BK metadata service URI, then delete these ledgers if it's specified (cherry picked from commit 9922249)
2 tasks
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
### Motivation apache#8169 introduced a command tool to delete a cluster's metadata from ZK. This PR intends to delete the cluster's ledgers from BK. ### Modifications - Retrieve ledger ids from related ZK nodes - Add an optional argument to specify BK metadata service URI, then delete these ledgers if it's specified
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation apache#8169 introduced a command tool to delete a cluster's metadata from ZK. This PR intends to delete the cluster's ledgers from BK. ### Modifications - Retrieve ledger ids from related ZK nodes - Add an optional argument to specify BK metadata service URI, then delete these ledgers if it's specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#8169 introduced a command tool to delete a cluster's metadata from ZK. This PR intends to delete the cluster's ledgers from BK.
Modifications
Verifying this change