Add read position when joining in the consumer stats. #8274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Oct 16, 2020
|
/pulsarbot run-failure-checks |
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
Motivation To troubleshooting the consumer stop to receive messages under the key_shared subscription, it's difficult to know if the broker stops to dispatch messages to this consumer to preserve order. So this PR exposes a metrics to show the read position when the consumer joining so that we can compare the read position and the mark delete position to determine. Verifying this change Unit test added (cherry picked from commit 8a846dc)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
Motivation To troubleshooting the consumer stop to receive messages under the key_shared subscription, it's difficult to know if the broker stops to dispatch messages to this consumer to preserve order. So this PR exposes a metrics to show the read position when the consumer joining so that we can compare the read position and the mark delete position to determine. Verifying this change Unit test added
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
Motivation To troubleshooting the consumer stop to receive messages under the key_shared subscription, it's difficult to know if the broker stops to dispatch messages to this consumer to preserve order. So this PR exposes a metrics to show the read position when the consumer joining so that we can compare the read position and the mark delete position to determine. Verifying this change Unit test added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To troubleshooting the consumer stop to receive messages under the key_shared subscription, it's difficult to know if the broker stops to dispatch messages to this consumer to preserve order. So this PR exposes a metrics to show the read position when the consumer joining so that we can compare the read position and the mark delete position to determine.
Verifying this change
Unit test added
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation