[component/functions|component/go] Add access to the current message from the function context #8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message from the function context
…xt before executing the handler
vaihtovirta
force-pushed
the
feat/pulsar-function-go/add-access-to-current-message
branch
from
485f726
to
4eeb76e
Compare
sijie
approved these changes
Oct 21, 2020
sijie
added
doc
vaihtovirta
deleted the
feat/pulsar-function-go/add-access-to-current-message
branch
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
…from the function context (apache#8290) ### Motivation It may be helpful to access the current message in order to access its metadata (key, properties, etc). ### Modifications - Implemented `FunctionContext#GetCurrentRecord` (similar to [Context#getCurrentRecord](https://github.com/apache/pulsar/blob/9c821cf940d422d2ea3d47687bd309fe698ab84e/pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java#L46)) - Implemented `FunctionContext#SetCurrentRecord` - Set current message before executing a message handler in `goInstance#handleMsg` ### Verifying this change - [x] Make sure that the change passes the CI checks.
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…from the function context (apache#8290) ### Motivation It may be helpful to access the current message in order to access its metadata (key, properties, etc). ### Modifications - Implemented `FunctionContext#GetCurrentRecord` (similar to [Context#getCurrentRecord](https://github.com/apache/pulsar/blob/9c821cf940d422d2ea3d47687bd309fe698ab84e/pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java#L46)) - Implemented `FunctionContext#SetCurrentRecord` - Set current message before executing a message handler in `goInstance#handleMsg` ### Verifying this change - [x] Make sure that the change passes the CI checks.
|
Checked with @freeznet - This PR already contains the required doc changes. The doc label needs a refresh. |
Anonymitaet
removed
the
doc-required
|
@momo-jun thanks, then I've unchecked the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It may be helpful to access the current message in order to access its metadata (key, properties, etc).
Modifications
FunctionContext#GetCurrentRecord(similar to Context#getCurrentRecord)FunctionContext#SetCurrentRecordgoInstance#handleMsgVerifying this change
This change added tests and can be verified as follows:
FunctionContext#GetCurrentRecordFunctionContext#SetCurrentRecordgoInstance#handlerMsgDoes this pull request potentially affect one of the following parts:
Documentation