Increasing timeout for pulsar client io threads to shutdown #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Oct 20, 2020
sijie
approved these changes
Oct 21, 2020
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
### Motivation We need to make a best effort to shutdown all threads when close() is on a pulsar client. If threads spawned by a client are not shutdown when close() returns, this may lead to classloading exceptions/issues if pulsar JARs are unloaded afterwards like the case in a Flink job. ### Modifications Increase the wait time for IO threads in the pulsar client to shutdown. (cherry picked from commit ace3087)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
) ### Motivation We need to make a best effort to shutdown all threads when close() is on a pulsar client. If threads spawned by a client are not shutdown when close() returns, this may lead to classloading exceptions/issues if pulsar JARs are unloaded afterwards like the case in a Flink job. ### Modifications Increase the wait time for IO threads in the pulsar client to shutdown.
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
) ### Motivation We need to make a best effort to shutdown all threads when close() is on a pulsar client. If threads spawned by a client are not shutdown when close() returns, this may lead to classloading exceptions/issues if pulsar JARs are unloaded afterwards like the case in a Flink job. ### Modifications Increase the wait time for IO threads in the pulsar client to shutdown.
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
) ### Motivation We need to make a best effort to shutdown all threads when close() is on a pulsar client. If threads spawned by a client are not shutdown when close() returns, this may lead to classloading exceptions/issues if pulsar JARs are unloaded afterwards like the case in a Flink job. ### Modifications Increase the wait time for IO threads in the pulsar client to shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to make a best effort to shutdown all threads when close() is on a pulsar client. If threads spawned by a client are not shutdown when close() returns, this may lead to classloading exceptions/issues if pulsar JARs are unloaded afterwards like the case in a Flink job.
Modifications
Increase the wait time for IO threads in the pulsar client to shutdown.