[Issue #8268][Pulsar Function] k8s runtime with go functions support #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
changed the title
freeznet
force-pushed
the
k8s-runtime-with-go-functions-support
branch
from
15b1220
to
cad7e66
Compare
|
@freeznet Can you add an integration test for this? |
sure, wip |
freeznet
force-pushed
the
k8s-runtime-with-go-functions-support
branch
from
f873c8e
to
e6599bf
Compare
|
/pulsarbot run-failure-checks |
freeznet
force-pushed
the
k8s-runtime-with-go-functions-support
branch
from
e6599bf
to
e87e125
Compare
|
/pulsarbot run-failure-checks |
sijie
reviewed
Oct 30, 2020
| @@ -52,7 +52,7 @@ public String getSecretsProviderClassName(Function.FunctionDetails functionDetai | |||
| case PYTHON: | |||
| return "secretsprovider.EnvironmentBasedSecretsProvider"; | |||
| case GO: | |||
| throw new UnsupportedOperationException(); | |||
| return ""; | |||
There was a problem hiding this comment.
We need to create an issue and add a comment here to link to the issue. Otherwise, we will eventually forget to add secrets provider.
There was a problem hiding this comment.
i have created a new issue #8425
@sijie thanks for your review. currently the pulsar repo do not have any integration test implemented with k8s runtime, maybe we should create a new issue to address the lack of integration test for k8s runtime. once the integration tests with k8s runtime implemented, then we can manage the integration tests with k8s runtime & golang functions. |
freeznet
force-pushed
the
k8s-runtime-with-go-functions-support
branch
from
e87e125
to
34ded0e
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
freeznet
force-pushed
the
k8s-runtime-with-go-functions-support
branch
from
34ded0e
to
bbbf01e
Compare
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…pport (apache#8352) Fixes apache#8268 ### Motivation currently, go function cannot work with k8s runtime other than java and python, this PR is intended to add go function support with k8s runtime. ### Modifications removed `UnsupportedOperationException` with GO function, fixed go function executable permissions, and fix arguments passed to go function with correct format. this PR is making k8s runtime with go function workable, but may not cover all k8s scenarios, so comments are welcome, also need some help with tests, havnt add any tests yet.
|
depends by #8780 |
codelipenghui
pushed a commit
that referenced
this pull request
Dec 7, 2020
…8352) Fixes #8268 ### Motivation currently, go function cannot work with k8s runtime other than java and python, this PR is intended to add go function support with k8s runtime. ### Modifications removed `UnsupportedOperationException` with GO function, fixed go function executable permissions, and fix arguments passed to go function with correct format. this PR is making k8s runtime with go function workable, but may not cover all k8s scenarios, so comments are welcome, also need some help with tests, havnt add any tests yet. (cherry picked from commit bd475c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8268
Motivation
currently, go function cannot work with k8s runtime other than java and python, this PR is intended to add go function support with k8s runtime.
Modifications
removed
UnsupportedOperationExceptionwith GO function, fixed go function executable permissions, and fix arguments passed to go function with correct format.this PR is making k8s runtime with go function workable, but may not cover all k8s scenarios, so comments are welcome, also need some help with tests, havnt add any tests yet.
Verifying this change
This change added tests and can be verified as follows:
tests WIP