Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Use Cancel workflow action to cancel outdated PR build jobs #8393

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 27, 2020

Motivation

Currently a single user can cause the Pulsar CI to get overloaded when commits are pushed to a PR branch frequently, one by one. To mitigate this issue, cancel any previous Github Actions runs that are not completed for a given workflow,
for a particular branch / PR. This can be achieved by using the https://github.com/marketplace/actions/cancel-workflow-action .
There are multiple cancel actions available. This particular one was picked based on its popularity.

Modifications

Append each workflow with the cancel workflow action step.

- Cancel any previous runs that are not completed for a given workflow
  for a particular branch / PR.
  - See https://github.com/marketplace/actions/cancel-workflow-action
@lhotari
Copy link
Member Author

lhotari commented Oct 27, 2020

/pulsarbot run-failure-checks

5 similar comments
@lhotari
Copy link
Member Author

lhotari commented Oct 27, 2020

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Oct 27, 2020

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Oct 27, 2020

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Oct 27, 2020

/pulsarbot run-failure-checks

@addisonj
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 82ae38e into apache:master Oct 28, 2020
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
Can you so the same on BK repo?

@lhotari
Copy link
Member Author

lhotari commented Oct 28, 2020

Can you so the same on BK repo?

@eolivelli it's apache/bookkeeper#2464

Ghatage pushed a commit to apache/bookkeeper that referenced this pull request Oct 28, 2020
### Motivation

Currently a single user can cause the Github Actions / Workflows based CI to get overloaded when commits are pushed to a PR branch frequently, one by one. To mitigate this issue, cancel any previous Github Actions runs that are not completed for a given workflow,  for a particular branch / PR. This can be achieved by using the https://github.com/marketplace/actions/cancel-workflow-action .
[There are multiple cancel actions available](https://github.community/t/github-actions-cancel-redundant-builds-not-solved/16025/22). This particular one was picked based on its popularity.

### Modifications

Append each workflow with the cancel workflow action step.

A similar change was made in Pulsar CI in PR apache/pulsar#8393

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Anup Ghatage <ghatage@apache.org>

This closes #2464 from lhotari/lh-cancel-previous-build
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
…pache#8393)

### Motivation

Currently a single user can cause the Pulsar CI to get overloaded when commits are pushed to a PR branch frequently, one by one. To mitigate this issue, cancel any previous Github Actions runs that are not completed for a given workflow,
  for a particular branch / PR. This can be achieved by using the https://github.com/marketplace/actions/cancel-workflow-action .
[There are multiple cancel actions available](https://github.community/t/github-actions-cancel-redundant-builds-not-solved/16025/22). This particular one was picked based on its popularity.

### Modifications

Append each workflow with the cancel workflow action step.
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
…pache#8393)

### Motivation

Currently a single user can cause the Pulsar CI to get overloaded when commits are pushed to a PR branch frequently, one by one. To mitigate this issue, cancel any previous Github Actions runs that are not completed for a given workflow,
  for a particular branch / PR. This can be achieved by using the https://github.com/marketplace/actions/cancel-workflow-action .
[There are multiple cancel actions available](https://github.community/t/github-actions-cancel-redundant-builds-not-solved/16025/22). This particular one was picked based on its popularity.

### Modifications

Append each workflow with the cancel workflow action step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants