New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP-71][SQL]Pulsar SQL migrate SchemaHandle to presto decoder #8422
Conversation
/pulsarbot run-failure-checks |
@gaoran10 Could you please help review this PR? |
move to 2.8.0 first. |
@gaoran10 to help review this PR |
@hnail Can you rebase this pull request to the latest master? |
Confirmed w/ @congbobo184, no need to update doc for this PR. |
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
@hnail @gaoran10 Could you please help take a look the failed test?
The interesting thing this why other tests are passed. Might be related to the other tests only run the install for profile |
@codelipenghui fixed. cc @gaoran10 @jiazhai |
@hnail Thanks a lot for this great feature. |
apache#8422)" This reverts commit a1107ad.
Fixes #4747
Fixes #7652
Motivation
PIP-71: https://github.com/apache/pulsar/wiki/PIP-71:-Pulsar-SQL-migrate-SchemaHandle-to-presto-decoder
Pip-Doc : [PIP-71][SQL]Migrate SchemaHandle to Presto-decoder
In current version , pulsar-presto deserialize fields rely on SchemaHandler , but this causes the following restrictions :
RecordCursor.getObject()
to support ROW,MAP,ARRAY .etcThe motivations of this pull request :
PulsarMetadata
take advantage ofParameterizedType
to describerow/array/map
Type instead of resolve nested columns in pulsar-presto connecter.RowDecoder | RowDecoderFactory | ColumnDecoder
to work with pulsar interface, and with some our own extensions compare to presto original version , we can support more type for backward compatible (e.g.TIMESTAMP\DATE\TIME\Real\ARRAY\MAP\ROW
support).pulsar-presto main module
(RecordSet,ConnectorMetadata .etc ), aim to friendly with other schema type ( ProtobufNative 、thrift etc..).Modifications
Describe in PIP-71: Pulsar SQL migrate SchemaHandle to presto decoder
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
[PIP][SQL]Migrate SchemaHandle to Presto-decoder