add rest api: unsetOffloadPolicies #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
gaoran10
reviewed
Nov 4, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Nov 4, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Nov 4, 2020
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Nov 4, 2020
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
Outdated
Show resolved
Hide resolved
codelipenghui
requested review from
codelipenghui,
hangc0276,
jiazhai,
rdhabalia and
sijie
gaoran10
reviewed
Nov 4, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
|
Great work. |
gaoran10
reviewed
Nov 4, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
…l/NamespacesBase.java Co-authored-by: ran <gaoran_10@126.com>
…l/NamespacesBase.java Co-authored-by: ran <gaoran_10@126.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
|
LGTM |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 5, 2020
|
@Renkai Seems the failed CI tests related to this PR, could you please help take a look? |
|
/pulsarbot run-failure-checks |
Signed-off-by: Renkai <gaelookair@gmail.com>
sijie
approved these changes
Nov 5, 2020
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Nov 5, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Renkai gaelookair@gmail.com
Fix: https://github.com/streamnative/pulsar/issues/1638
Add a unset mirror of setOffloadPolicies
Motivation
Currently we don't have a way to unset offload policies for namespaces, we may need one.
Modifications
Add a rest API
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation