Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BookKeeper to 4.12.0 #8447

Merged
merged 7 commits into from
Nov 16, 2020
Merged

Upgrade BookKeeper to 4.12.0 #8447

merged 7 commits into from
Nov 16, 2020

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Nov 4, 2020 •
edited
Loading

Upgrade Apache BookKeeper to 4.12.0

Most notable changes that impact this patch are:

  • BP-41 -> "BookieSocketAddress" becomes "BookieId"
  • BP-42 -> LedgerMetadata now carries "ledgerId" (as a transient non serialized value)

@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-tests

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-checks

@eolivelli eolivelli changed the title Upgrade BookKeeper to 4.12.0 preview - DO NOT MERGE Upgrade BookKeeper to 4.12.0 Nov 16, 2020
@eolivelli eolivelli marked this pull request as ready for review November 16, 2020 08:04
@eolivelli
Copy link
Contributor Author

@jiazhai now that you released BK 4.12.0 this patch should be good to go as soon as CI passes

@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-tests

2 similar comments
@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-tests

@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-tests

@eolivelli
Copy link
Contributor Author

@jiazhai @codelipenghui @sijie @merlimat @rdhabalia
the patch is ready for review.
The failures on CI are not caused by the upgrade, some day ago with BK 4.12.0-SNAPSHOT all of the tests passed
they look like flaky tests

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 1907afe into apache:master Nov 16, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Nov 16, 2020
@eolivelli eolivelli deleted the fix/update-bk-4.12.0 branch November 16, 2020 13:24
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
@eolivelli @flowchartsman
Upgrade BookKeeper to 4.12.0 (apache#8447)
3ae66f3 
Upgrade Apache BookKeeper to 4.12.0

Most notable changes that impact this patch are:
- BP-41 -> "BookieSocketAddress" becomes "BookieId"
- BP-42 -> LedgerMetadata now carries "ledgerId" (as a transient non serialized value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@eolivelli eolivelli

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eolivelli @codelipenghui