[Pulsar Proxy] Add error log for pulsar proxy starter #8451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Nov 5, 2020
|
cherry-picked to branch-2.6 |
codelipenghui
pushed a commit
that referenced
this pull request
Nov 10, 2020
### Motivation Currently, the proxy service starter will throw all exceptions to the main method directly, it's hard to check the error log if there is an exception when proxy service start. ### Modifications Add try-catch for proxy start method. (cherry picked from commit 442a547)
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Nov 13, 2020
### Motivation Currently, the proxy service starter will throw all exceptions to the main method directly, it's hard to check the error log if there is an exception when proxy service start. ### Modifications Add try-catch for proxy start method. (cherry picked from commit 442a547) (cherry picked from commit bcb97d1)
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation Currently, the proxy service starter will throw all exceptions to the main method directly, it's hard to check the error log if there is an exception when proxy service start. ### Modifications Add try-catch for proxy start method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the proxy service starter will throw all exceptions to the main method directly, it's hard to check the error log if there is an exception when proxy service start.
Modifications
Add try-catch for proxy start method.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation