[Transaction] Register transaction metadata before send or ack messages #8493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
Comment on lines
+479
to
+480
| .thenCompose(ignored -> doAcknowledge(messageIdList, ackType, properties, txn)); | ||
| txn.registerAckOp(ackFuture); |
There was a problem hiding this comment.
Should we handle the exception here? If the metadata register failed, we can't send message or ack
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 10, 2020
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
txn-register-before-send
branch
from
d4f1f63
to
522489b
Compare
gaoran10
force-pushed
the
txn-register-before-send
branch
from
a18f29d
to
dd1fc52
Compare
|
/pulsarbot run-failure-checks |
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…es (apache#8493) The transaction metadata registration should be the precondition of send or ack transaction messages, this guarantees TC could notify all related topic partitions and subscriptions successfully.
This was referenced Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/streamnative/pulsar/issues/1659
Motivation
The transaction metadata registration should be the precondition of send or ack transaction messages, this guarantees TC could notify all related topic partitions and subscriptions successfully.
Modifications
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation