-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdminCli] Add ability to examine specific message by position relative to earliest or latest message. #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge mainline to zxc's personal repo.
@zymap Would you please also take a look at this PR? |
jiazhai
reviewed
Nov 10, 2020
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
Outdated
Show resolved
Hide resolved
zymap
reviewed
Nov 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
sijie
approved these changes
Nov 11, 2020
codelipenghui
approved these changes
Nov 11, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…ve to earliest or latest message. (apache#8494) Fixes apache#5126 ### Motivation Add ability to examine specific message by position relative to earliest or latest message. So we can easily debug with topic without need to create subscription or fetch message by getting position(legerId:entryId) for that message first. ### Modifications Add rest and cli command to get specific message from a topic position relative to earliest/latest message. Exposed asyncReadEntry, getFirstPosition, getPositionAfterN and getNumberOfEntries in PersistentTopic to help implementing it..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
type/feature
The PR added a new feature or issue requested a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5126
Motivation
Add ability to examine specific message by position relative to earliest or latest message.
So we can easily debug with topic without need to create subscription or fetch message by getting position(legerId:entryId) for that message first.
Modifications
Add rest and cli command to get specific message from a topic position relative to earliest/latest message.
Exposed asyncReadEntry, getFirstPosition, getPositionAfterN and getNumberOfEntries in PersistentTopic to help implementing it..
Verifying this change
This change added tests and can be verified as follows:
Added unit test.
Does this pull request potentially affect one of the following parts:
Documentation