Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminCli] Add ability to examine specific message by position relative to earliest or latest message. #8494

Merged
merged 7 commits into from
Nov 11, 2020

Conversation

MarvinCai
Copy link
Contributor

@MarvinCai MarvinCai commented Nov 10, 2020

Fixes #5126

Motivation

Add ability to examine specific message by position relative to earliest or latest message.
So we can easily debug with topic without need to create subscription or fetch message by getting position(legerId:entryId) for that message first.

Modifications

Add rest and cli command to get specific message from a topic position relative to earliest/latest message.
Exposed asyncReadEntry, getFirstPosition, getPositionAfterN and getNumberOfEntries in PersistentTopic to help implementing it..

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
Added unit test.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: yes
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@jiazhai
Copy link
Member

jiazhai commented Nov 10, 2020

@zymap Would you please also take a look at this PR?

Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added area/cli type/feature The PR added a new feature or issue requested a new feature labels Nov 11, 2020
@sijie sijie added this to the 2.7.0 milestone Nov 11, 2020
@sijie sijie added the doc-required Your PR changes impact docs and you will update later. label Nov 11, 2020
@codelipenghui codelipenghui merged commit fdcf613 into apache:master Nov 11, 2020
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
…ve to earliest or latest message. (apache#8494)

Fixes apache#5126 

### Motivation

Add ability to examine specific message by position relative to earliest or latest message.
So we can easily debug with topic without need to create subscription or fetch message by getting position(legerId:entryId) for that message first.

### Modifications

Add rest and cli command to get specific message from a topic position relative to earliest/latest message.
Exposed asyncReadEntry, getFirstPosition, getPositionAfterN and getNumberOfEntries in PersistentTopic to help implementing it..
@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-required Your PR changes impact docs and you will update later. labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume from/to offset API
6 participants