Cancel producer sendtimeout task after creation failure #8497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrsakai
added
type/bug
codelipenghui
approved these changes
Nov 10, 2020
codelipenghui
requested review from
jiazhai,
sijie,
merlimat,
massakam,
rdhabalia and
hangc0276
sijie
approved these changes
Nov 10, 2020
|
cherry-picked to branch-2.6 |
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Nov 13, 2020
### Motivation SendTimeout task is being started in the ProducerImpl constructor though it is not being cancelled if the producer creation fails, leaving active ref to that object. This problem looks like a problem similar to apache#5204. (cherry picked from commit 73b4c3d) (cherry picked from commit 85db6b6)
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation SendTimeout task is being started in the ProducerImpl constructor though it is not being cancelled if the producer creation fails, leaving active ref to that object. This problem looks like a problem similar to apache#5204.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SendTimeout task is being started in the ProducerImpl constructor though it is not being cancelled if the producer creation fails, leaving active ref to that object.
This problem looks like a problem similar to #5204.