[pulsar-perf] Support WebSocket Producer for V2 Topics #8535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zymap
reviewed
Nov 12, 2020
| @@ -166,7 +168,9 @@ public void runPerformanceTest(long messages, long limit, int numOfTopic, int si | |||
| String topicName, String authPluginClassName, String authParams) throws InterruptedException, FileNotFoundException { | |||
| ExecutorService executor = Executors.newCachedThreadPool(new DefaultThreadFactory("pulsar-perf-producer-exec")); | |||
| HashMap<String, Tuple> producersMap = new HashMap<>(); | |||
| String produceBaseEndPoint = baseUrl + "ws/producer" + topicName; | |||
| String replacedTopicName = topicName.replace("://", "/"); | |||
There was a problem hiding this comment.
I think there has a method getRestPath in the TopicName do the same thing with you.
There was a problem hiding this comment.
Thank you for the advice.
I fixed it.
zymap
approved these changes
Nov 13, 2020
…_producer_for_v2_topic
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Nov 13, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation - Not support v2 topics. - Not working because `/` is missing between `"ws/producer" and topicName` https://github.com/apache/pulsar/blob/1c7b12d379cf36183d60919dcaff75e4d6cf63f2/pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java#L169 ### Modifications - Fix that if use V2 topics, use "ws/v2/producer/".
|
/pulsarbot cherry-pick to branch-2.6 |
codelipenghui
pushed a commit
that referenced
this pull request
Nov 21, 2020
### Motivation - Not support v2 topics. - Not working because `/` is missing between `"ws/producer" and topicName` https://github.com/apache/pulsar/blob/1c7b12d379cf36183d60919dcaff75e4d6cf63f2/pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java#L169 ### Modifications - Fix that if use V2 topics, use "ws/v2/producer/". (cherry picked from commit 67f544c)
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Nov 21, 2020
### Motivation - Not support v2 topics. - Not working because `/` is missing between `"ws/producer" and topicName` https://github.com/apache/pulsar/blob/1c7b12d379cf36183d60919dcaff75e4d6cf63f2/pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java#L169 ### Modifications - Fix that if use V2 topics, use "ws/v2/producer/". (cherry picked from commit 67f544c) (cherry picked from commit 81d5caa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
/is missing between"ws/producer" and topicNamepulsar/pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
Line 169 in 1c7b12d
Modifications