Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose consumer names after the mark delete position for the Key_Shared subscription #8545

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Expose consumer names after the mark delete position for the Key_Shared subscription #8545

merged 3 commits into from
Nov 13, 2020

Conversation

codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Nov 12, 2020 •
edited

Motivation

  1. Expose consumer names after the mark delete position for the Key_Shared subscription.
  2. Remove the consumer from the recenlyJoinedConsumer depends on the valid next position of the next position. Previously, we use the position.nextPosition to decide to remove the consumer from the recenlyJoinedConsumer but this will lead to consumers can't be deleted property. For example, if ledger rollover and the mark delete position is the last position of the old ledger and the max read position is the first position of the new ledger, In this situation, we should remove the consumer from the recenlyJoinedConsumer but in fact, it will stay in the recenlyJoinedConsumer because the max read position always greater than the markDeletePosition.nextPosition.

So we should get the valid next position for the mark delete position.

Related to #8499

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Nov 12, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Nov 12, 2020
@codelipenghui codelipenghui merged commit 6867262 into apache:master Nov 13, 2020
@codelipenghui codelipenghui deleted the penghui/expose_after_consumer branch November 13, 2020 11:36
codelipenghui added a commit that referenced this pull request Nov 13, 2020
@codelipenghui
Expose consumer names after the mark delete position for the Key_Shar…
7b55504 
…ed subscription (#8545)

1. Expose consumer names after the mark delete position for the Key_Shared subscription.
2. Remove the consumer from the recenlyJoinedConsumer depends on the valid next position of the next position. Previously, we use the position.nextPosition to decide to remove the consumer from the recenlyJoinedConsumer but this will lead to consumers can't be deleted property. For example, if ledger rollover and the mark delete position is the last position of the old ledger and the max read position is the first position of the new ledger, In this situation, we should remove the consumer from the recenlyJoinedConsumer but in fact, it will stay in the recenlyJoinedConsumer because the max read position always greater than the `markDeletePosition.nextPosition`.

So we should get the valid next position for the mark delete position.

Related to #8499

(cherry picked from commit 6867262)
codelipenghui added a commit to streamnative/pulsar-archived that referenced this pull request Nov 13, 2020
@codelipenghui
Expose consumer names after the mark delete position for the Key_Shar…
e1abbe5 
…ed subscription (apache#8545)

1. Expose consumer names after the mark delete position for the Key_Shared subscription.
2. Remove the consumer from the recenlyJoinedConsumer depends on the valid next position of the next position. Previously, we use the position.nextPosition to decide to remove the consumer from the recenlyJoinedConsumer but this will lead to consumers can't be deleted property. For example, if ledger rollover and the mark delete position is the last position of the old ledger and the max read position is the first position of the new ledger, In this situation, we should remove the consumer from the recenlyJoinedConsumer but in fact, it will stay in the recenlyJoinedConsumer because the max read position always greater than the `markDeletePosition.nextPosition`.

So we should get the valid next position for the mark delete position.

Related to apache#8499

(cherry picked from commit 6867262)
(cherry picked from commit 7b55504)
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
@codelipenghui @flowchartsman
Expose consumer names after the mark delete position for the Key_Shar…
7b56d4c 
…ed subscription (apache#8545)

### Motivation

1. Expose consumer names after the mark delete position for the Key_Shared subscription.
2. Remove the consumer from the recenlyJoinedConsumer depends on the valid next position of the next position. Previously, we use the position.nextPosition to decide to remove the consumer from the recenlyJoinedConsumer but this will lead to consumers can't be deleted property. For example, if ledger rollover and the mark delete position is the last position of the old ledger and the max read position is the first position of the new ledger, In this situation, we should remove the consumer from the recenlyJoinedConsumer but in fact, it will stay in the recenlyJoinedConsumer because the max read position always greater than the `markDeletePosition.nextPosition`. 

So we should get the valid next position for the mark delete position.

Related to apache#8499
codelipenghui added a commit to streamnative/pulsar-archived that referenced this pull request Nov 21, 2020
@codelipenghui
Expose consumer names after the mark delete position for the Key_Shar…
18668d5 
…ed subscription (apache#8545)

1. Expose consumer names after the mark delete position for the Key_Shared subscription.
2. Remove the consumer from the recenlyJoinedConsumer depends on the valid next position of the next position. Previously, we use the position.nextPosition to decide to remove the consumer from the recenlyJoinedConsumer but this will lead to consumers can't be deleted property. For example, if ledger rollover and the mark delete position is the last position of the old ledger and the max read position is the first position of the new ledger, In this situation, we should remove the consumer from the recenlyJoinedConsumer but in fact, it will stay in the recenlyJoinedConsumer because the max read position always greater than the `markDeletePosition.nextPosition`.

So we should get the valid next position for the mark delete position.

Related to apache#8499

(cherry picked from commit 6867262)
(cherry picked from commit 7b55504)
(cherry picked from commit e1abbe5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@codelipenghui codelipenghui

Labels
release/2.6.3
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codelipenghui @sijie @jiazhai