Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6478: Fix the misleading setting in presto configuration #8549

Merged
merged 25 commits into from
May 22, 2021

Conversation

sijie
Copy link
Member

@sijie sijie commented Nov 12, 2020

Motivation

Fixes #6748

This is a fork of #6757 after rebased to the latest master.

@sijie sijie added this to the 2.7.0 milestone Nov 12, 2020
@sijie sijie self-assigned this Nov 12, 2020
@Jennifer88huang-zz
Copy link
Contributor

Since the issue was first raised in April, we should adopt the doc changes ever since 2.5.1 release. How about releases earlier than 2.5.1?

@sijie
Copy link
Member Author

sijie commented Nov 13, 2020

@jennifer88huang No. It should impact the releases onwards.

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@Jennifer88huang-zz
Copy link
Contributor

@jennifer88huang No. It should impact the releases onwards.

Got it, thank you.

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

Error:  Tests run: 4, Failures: 2, Errors: 0, Skipped: 2, Time elapsed: 73.116 s <<< FAILURE! - in TestSuite
Error:  pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto)  Time elapsed: 1.03 s  <<< FAILURE!
org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 6f4ea4f7267b7a375cfa1742c06a06c7a7a7ac24e9b2b4e91731c3ffede237dd with error code 1
	at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259)
	at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51)
	at com.github.dockerjava.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$4(OkHttpInvocationBuilder.java:331)
	at java.lang.Thread.run(Thread.java:748)

Error:  pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto)  Time elapsed: 1.015 s  <<< FAILURE!
org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 6f4ea4f7267b7a375cfa1742c06a06c7a7a7ac24e9b2b4e91731c3ffede237dd with error code 1
	at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259)
	at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51)
	at com.github.dockerjava.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$4(OkHttpInvocationBuilder.java:331)
	at java.lang.Thread.run(Thread.java:748)

@sijie sijie modified the milestones: 2.7.0, 2.8.0 Nov 18, 2020
@Anonymitaet
Copy link
Member

Hi @sijie could you please help resolve the conflicts? And then we can merge this PR, thanks.

@Anonymitaet
Copy link
Member

@sijie any progress on this PR?

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit f807fed into apache:master May 22, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
…e#8549)

*Motivation*

Fixes apache#6748

This is a fork of apache#6757 after rebased to the latest master.
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…e#8549)

*Motivation*

Fixes apache#6748

This is a fork of apache#6757 after rebased to the latest master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql Pulsar SQL related features doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulsar.broker-service-url is misleading in presto configuration
6 participants