[Transaction] Guarantee transaction metadata handlers connect #8563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested changes
Nov 13, 2020
| }); | ||
| } else { | ||
| return FutureUtil.failedFuture(new CoordinatorClientStateException("Can not start while current state is " + state)); | ||
| } | ||
| } | ||
|
|
||
| private String getTCAssignTopicName(int partition) { | ||
| if (partition > 0) { |
There was a problem hiding this comment.
Suggested change
| if (partition > 0) { | |
| if (partition >= 0) { |
There was a problem hiding this comment.
Ok, I'll fix this.
codelipenghui
approved these changes
Nov 13, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
Thanks @gaoran10 for fixing this problem so quickly, this is very valuable to me. |
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…#8563) ### Motivation Currently, the transaction metadata handlers start with pulsar client start, but the handlers connect with the broker asynchronously, if the client restart, the metadata handler may not be available. ### Modifications Add the connection future for the metadata handler.
This was referenced Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the transaction metadata handlers start with pulsar client start, but the handlers connect with the broker asynchronously, if the client restart, the metadata handler may not be available.
Modifications
Add the connection future for the metadata handler.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes