-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+) #8576
Issue 8558: Upgrade Kubernetes client and remove sundr-codegen (allow Pulsar to run on JDK14+) #8576
Conversation
- remove sundr-codegen from distribution lib - allow Pulsar bookie to run on JDK14+
@codelipenghui PTAL to this change as well, otherwise it is not possible to run Pulsar on JDK14+ using the standard package. at MagNews.com we are already running Pulsar Broker on JDK14 and also JDK15 without issues, but we are not using the ASF package |
@eolivelli Have you verified if this change works for running functions with Kubernetes runtime? |
@sijie no I didn't and I do not have a way to do it right now, I am sorry. It would be really better to test it |
@eolivelli I would like to hold on this until 2.7.0 is released. Because we found upgrading Kubernetes version potentially broke the build in the past (see #8601). |
@sijie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add an integration test framework to test kubernetes runtime. @wolfstudy Can you help with that?
@wolfstudy feel free to pick up this patch |
@wolfstudy do you have time to pick up this issue ? |
@eolivelli Sorry, I missed this message, Sure, I will try to add an integration test to cover this change |
@wolfstudy if you do not have cycles |
@wolfstudy @sijie I am going to try out this brach on a K8s cluster manually. |
@sijie @wolfstudy We can add system tests, probably the best place would be nearby the helm-chart and not in this repository. |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
@eolivelli I think the integration tests should be added in this repo. The helm chart repo is used for testing the helm chart. You can clone the helm chart repo in the CI job to start a KIND cluster for testing. |
@sijie agreed, we can make it here (or in the new 'release repo' once PIP-62 is completed I created a new issue |
@rdhabalia @merlimat @codelipenghui PTAL as well |
@codelipenghui @congbobo184 @wolfstudy can you please take a look ? |
I have merged with current master in order to bootstrap CI again. Thank you @sijie for taking a look |
/pulsarbot run-failure-tests |
@wolfstudy can you please help merging this patch ? |
/pulsarbot run-failure-tests |
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
@wolfstudy @codelipenghui @rdhabalia CI finally passed. |
Fixes #8558
Motivation
sundr-codegen jar is not needed at runtime and in bundles legacy versions of commons-lang and other libraries, this is polluting the runtime classpath of Pulsar Broker,Bookie,Functions...
The depedency comes from Kubernetes java client, used by Pulsar Functions.
sundrio/sundrio#153
Modifications
Verifying this change
I have verified this change manually.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changes