Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data source priority configuration for offloaded messages #8678

Closed
wants to merge 5 commits into from
Closed

Add data source priority configuration for offloaded messages #8678

wants to merge 5 commits into from

Conversation

Renkai
Copy link
Contributor

@Renkai Renkai commented Nov 24, 2020

Main issue: #8591

This PR add a configuration about data source priority for offloaded messages, related implementations are not included.

@Renkai
add configuration for read priority
b0f5218 
Signed-off-by: Renkai <gaelookair@gmail.com>
@Renkai
add read priority to offload policy
f31278d 
Signed-off-by: Renkai <gaelookair@gmail.com>
@Renkai
add read priority to offload policy
c4dda85 
Signed-off-by: Renkai <gaelookair@gmail.com>
@Renkai
add read priority to offload policy
6837fff 
Signed-off-by: Renkai <gaelookair@gmail.com>
@Renkai
add read priority to offload policy
86bbd71 
Signed-off-by: Renkai <gaelookair@gmail.com>
@Renkai
Copy link
Contributor Author

Renkai commented Nov 24, 2020

/pulsarbot run-failure-checks

2 similar comments
@Renkai
Copy link
Contributor Author

Renkai commented Nov 24, 2020

/pulsarbot run-failure-checks

@Renkai
Copy link
Contributor Author

Renkai commented Nov 24, 2020

/pulsarbot run-failure-checks

sijie
sijie requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be merged as the last commit. Otherwise, we are merging a feature without implementation. That can cause confusion to a lot of people.

@Renkai
Copy link
Contributor Author

Renkai commented Nov 25, 2020

This change should be merged as the last commit. Otherwise, we are merging a feature without implementation. That can cause confusion to a lot of people.

My initial think to separate this PIP to multiple PRs is to reduce merge conflicts and find problems at early stage, if a big patch with all things included is the idiomatic way here, I will try to supplement the rest content

@Renkai
Copy link
Contributor Author

Renkai commented Nov 26, 2020

Full PR at #8717

@Renkai Renkai closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Renkai @sijie