Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered Storage] Fix Jclouds Azure credential error #8693

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Nov 25, 2020

Motivation

Currently, the tiered storage Azure credential is broken.

Modifications

Change the Azure supplier credential.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

@gaoran10 gaoran10 force-pushed the fix-jclouds-azure-credentials branch from b2635cf to 35b55dd Compare November 25, 2020 14:26
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaoran10 The change looks good. Is it possible to add a test case to catch this issue?

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@sijie sijie merged commit bf9f619 into apache:master Nov 26, 2020
codelipenghui pushed a commit that referenced this pull request Nov 26, 2020
### Motivation

Currently, the tiered storage Azure credential is broken.

### Modifications

Change the Azure supplier credential.

(cherry picked from commit bf9f619)
@gaoran10 gaoran10 deleted the fix-jclouds-azure-credentials branch November 30, 2020 03:09
zymap pushed a commit to streamnative/pulsar-archived that referenced this pull request Nov 30, 2020
### Motivation

Currently, the tiered storage Azure credential is broken.

### Modifications

Change the Azure supplier credential.

(cherry picked from commit bf9f619)
codelipenghui pushed a commit that referenced this pull request Dec 3, 2020
### Motivation

Currently, the tiered storage Azure credential is broken.

### Modifications

Change the Azure supplier credential.

(cherry picked from commit bf9f619)
codelipenghui pushed a commit to streamnative/pulsar-archived that referenced this pull request Dec 3, 2020
### Motivation

Currently, the tiered storage Azure credential is broken.

### Modifications

Change the Azure supplier credential.

(cherry picked from commit bf9f619)
(cherry picked from commit 63d553f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants