[WebSocket] Fix the initial sequence id error #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/fix-websocket-cli-params
branch
from
90b03ce
to
23dc705
Compare
zymap
reviewed
Nov 27, 2020
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ProducerHandler.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
BewareMyPower
changed the title
BewareMyPower
changed the title
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Nov 30, 2020
|
/pulsarbot cherry-pick to branch-2.7 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
### Motivation The WebSocket `ProducerHandler` parse a wrong string so the client's query param `initialSequenceId` will always fail. ### Modifications - Parse the real `initialSequenceId` value. - Add unit tests to ensure that all params from the WebSocket url can be converted to the right config. ### Verifying this change - [x] Make sure that the change passes the CI checks. (cherry picked from commit be39f50)
codelipenghui
added a commit
that referenced
this pull request
Dec 2, 2020
### Motivation The WebSocket `ProducerHandler` parse a wrong string so the client's query param `initialSequenceId` will always fail. ### Modifications - Parse the real `initialSequenceId` value. - Add unit tests to ensure that all params from the WebSocket url can be converted to the right config. ### Verifying this change - [x] Make sure that the change passes the CI checks. (cherry picked from commit be39f50) Co-authored-by: Yunze Xu <xyzinfernity@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The WebSocket
ProducerHandlerparse a wrong string so the client's query paraminitialSequenceIdwill always fail.Modifications
initialSequenceIdvalue.Verifying this change
This change added tests and can be verified as follows:
AbstractWebSocketHandlerTest#producerBuilderTestAbstractWebSocketHandlerTest#consumerBuilderTest