[C++] Fixed flaky test: AuthPluginTest.testTlsDetectHttpsWithHostNameValidation #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
aahmed-se,
codelipenghui,
ivankelly,
jerrypeng and
srkukarni
eolivelli
approved these changes
Dec 1, 2020
codelipenghui
approved these changes
Dec 2, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 2, 2020
codelipenghui
added
release/2.7.1
cherry-picked/branch-2.7
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
…Validation (apache#8771) * [C++] Fixed flaky test: AuthPluginTest.testTlsDetectHttpsWithHostNameValidation * Fixed test assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The test is wrong because the assertion is never checked, since we're not throwing exception when the hostname validation fails. It is also causing a segfault, because the promise object is already destroyed when the callback is triggered in background.