-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setter for the reader subscription name #8801
Conversation
/pulsarbot run-failure-checks |
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
I left a few little comments about the test.
Can you please check?
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
Fixes apache#8787 ### Motivation In the current reader, we set the subscription name combine with a random part. ### Modifications add subscription setter ### Verifying this change ReaderTest#testReaderSubName
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*.
…he#8823) Master Issue: apache#8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at apache#8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*.
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*. (cherry picked from commit 408f9e6)
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*. (cherry picked from commit 408f9e6)
### Motivation allow config reader's subscription name, follow java's feature apache/pulsar#8801 ### Modifications add param `SubscriptionName` in `ReaderOptions` ### Verifying this change add the test for setting the subscritpion name
Fixes #8787
Motivation
In the current reader, we set the subscription name combine with a random part.
Modifications
add subscription setter
Verifying this change
ReaderTest#testReaderSubName