Add setter for the reader subscription name #8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
zymap
reviewed
Dec 3, 2020
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
RobertIndie
reviewed
Dec 3, 2020
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
eolivelli
requested changes
Dec 4, 2020
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Show resolved
Hide resolved
sijie
added
area/client
doc-required
sijie
approved these changes
Dec 4, 2020
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Dec 4, 2020
|
/pulsarbot run-failure-checks |
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
Fixes apache#8787 ### Motivation In the current reader, we set the subscription name combine with a random part. ### Modifications add subscription setter ### Verifying this change ReaderTest#testReaderSubName
sijie
pushed a commit
that referenced
this pull request
Dec 8, 2020
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*.
zymap
pushed a commit
to zymap/pulsar
that referenced
this pull request
Dec 9, 2020
…he#8823) Master Issue: apache#8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at apache#8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*. (cherry picked from commit 408f9e6)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
Master Issue: #8787 ### Motivation Currently, the reader subscription name can only be generated internally randomly in the C++ client. Java client part is at #8801 ### Modifications Add a setter for the reader's internal subscription name. ### Verifying this change This change is already covered by existing tests, such as *testSubscriptionNameSetting*, *testSetSubscriptionNameAndPrefix* and *testMultiSameSubscriptionNameReaderShouldFail*. (cherry picked from commit 408f9e6)
Anonymitaet
removed
the
doc-required
wolfstudy
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Mar 29, 2022
### Motivation allow config reader's subscription name, follow java's feature apache/pulsar#8801 ### Modifications add param `SubscriptionName` in `ReaderOptions` ### Verifying this change add the test for setting the subscritpion name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8787
Motivation
In the current reader, we set the subscription name combine with a random part.
Modifications
add subscription setter
Verifying this change
ReaderTest#testReaderSubName