Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the packages management administration opeartions. #8816

Merged

Conversation

zymap
Copy link
Member

@zymap zymap commented Dec 3, 2020


Master Issue: #8676

Motivation

Introduce the pulsar admin operations with packages management service.

Modifications

  • Add the admin API for packages management service.

This only has client-side code. Will add integration tests when
server-side code is merged.

---

Master Issue: apache#8676

*Motivation*

Introduce the pulsar admin operations with packages management service.

*Modifications*

- Add the admin API for packages management service.

This is only have client-side code. Will add integration tests when
server-side code is merged.
@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

/pulsarbot run-failure-checks

1 similar comment
@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.8.0 milestone Dec 7, 2020
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add unit tests for the new admin APIs?

@codelipenghui codelipenghui added the doc-required Your PR changes impact docs and you will update later. label Dec 7, 2020
@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

@codelipenghui It might a little bit difficult to add unit tests for this. Because this change is adding some client code for package management service and there is no server code for that.
I want to add integration tests for this service when the server code is ready. Does this make sense to you?

@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

/pulsarbot run-failure-checks

2 similar comments
@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Dec 7, 2020

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 54f3e9c into apache:master Dec 7, 2020
RobertIndie pushed a commit to RobertIndie/pulsar that referenced this pull request Dec 8, 2020
…8816)

---

Master Issue: apache#8676

*Motivation*

Introduce the pulsar admin operations with packages management service.

*Modifications*

- Add the admin API for packages management service.

This only has client-side code. Will add integration tests when
server-side code is merged.
@Jennifer88huang-zz
Copy link
Contributor

@zymap we've added related content in #9071, shall we enable those pulsar-admin commands on the CLI page?

@Anonymitaet
Copy link
Member

#10568

Package is shown on the REST API doc.

image

@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants