[pulsar-zookeeper-utils] Fix Updating Rack Info Dynamically #8844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Dec 7, 2020
jiazhai
approved these changes
Dec 7, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
### Motivation When the value of "/bookies" in ZooKeeper is changed, Brokers are notified of the change. After the notification to Brokers, only one of the two BookKeeper clients that Brokers have seems to reflect the change. **Two BookKeeper clients that Brokers have** - https://github.com/apache/pulsar/blob/ac0c6e41f0ebe3c900bb31e41c8d40b3f60b19df/pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java#L81 - https://github.com/apache/pulsar/blob/102fa9de03509b86e47f58ab8e1c0dde2095da3b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java#L105 The client of `BookkeeperSchemaStorage` don't seems to reflect the change. The cause is that `ZkBookieRackAffinityMapping#onUpdate` don't run. I confirmed that I change ZkBookieRackAffinityMapping instances to use same `ZooKeeperDataCache` and `ZkBookieRackAffinityMapping#onUpdate` works. ### Modification - Set the argument of `ZkBookieRackAffinityMapping#setConf` to `bookieMappingCache` - Move `updateRacksWithHost()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the value of "/bookies" in ZooKeeper is changed, Brokers are notified of the change.
After the notification to Brokers, only one of the two BookKeeper clients that Brokers have seems to reflect the change.
Two BookKeeper clients that Brokers have
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
Line 81 in ac0c6e4
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java
Line 105 in 102fa9d
The client of
BookkeeperSchemaStoragedon't seems to reflect the change.The cause is that
ZkBookieRackAffinityMapping#onUpdatedon't run.I confirmed that I change ZkBookieRackAffinityMapping instances to use same
ZooKeeperDataCacheandZkBookieRackAffinityMapping#onUpdateworks.Modification
ZkBookieRackAffinityMapping#setConftobookieMappingCacheupdateRacksWithHost()