Export Prometheus metric for messageTTL #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Dec 9, 2020
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 10, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Jan 6, 2021
Fixes #8573 Some users who want to know how many messages are expired at what time? Currently, these metrics are too few, so that TTL looks like a black box, unobservable add `totalMsgExpired`、`lastExpireTimestamp`、`msgRateExpired` for Prometheus metric PrometheusMetricsTest.java (cherry picked from commit 060e35b)
codelipenghui
added
release/2.7.1
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
Fixes #8573 Some users who want to know how many messages are expired at what time? Currently, these metrics are too few, so that TTL looks like a black box, unobservable add `totalMsgExpired`、`lastExpireTimestamp`、`msgRateExpired` for Prometheus metric PrometheusMetricsTest.java (cherry picked from commit 060e35b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8573
Motivation
Some users who want to know how many messages are expired at what time? Currently, these metrics are too few, so that TTL looks like a black box, unobservable
Modifications
add
totalMsgExpired、lastExpireTimestamp、msgRateExpiredfor Prometheus metricVerifying this change
PrometheusMetricsTest.java