-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth action for package management service #8893
Conversation
59ed5cd
to
310c877
Compare
--- Master Issue: apache#8676 *Motivation* Add auth action 'package' for package management operations. Only the role who is granted the 'package' permission can do the package operations. *Modifications* - Add 'package' auth action and check the permissions when access the REST API - Add integration test for this *Verify this change* - Add integraion test for this
310c877
to
45cc622
Compare
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
@codelipenghui Please take a look when you have time. Thanks. |
...roker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.java
Outdated
Show resolved
Hide resolved
517fd34
to
aedc6ae
Compare
@sijie I use the |
/pulsarbot run-failure-checks |
We need to add finer granular permissions for package management. |
@sijie Ok. I open a new issue #9122 to track that and reconsider the auth implement in the package management service. I will improve the permissions in the package management with another PR. |
@zymap why do you need a separate issue? We are introducing auth action for the first time. We should get the implementation correctly. Let's not merge this until we have a correct implementation. |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
@sijie I improve the auth implement. Please take a look when you have time. Thanks. |
/pulsarbot run-failure-checks |
5 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zymap overall looks strong to me! +1
Thanks! |
Master Issue: #8676
Motivation
Add auth action 'package' for package management operations.
Only the role who is granted the 'package' permission can do
the package operations.
Modifications
Verify this change