[Pulsar C++ Client] make pool connections configurable in perf tools #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Dec 11, 2020
ltamber
changed the title
ltamber
changed the title
|
/pulsarbot run-failure-checks |
sijie
added
component/c++
area/cli
type/enhancement
|
/pulsarbot run-failure-checks |
|
You should use clang-format 5.0 to reformat your code. diff --git a/pulsar-client-cpp/perf/PerfConsumer.cc b/pulsar-client-cpp/perf/PerfConsumer.cc
index 7f2deb78792..6717fdeb827 100644
--- a/pulsar-client-cpp/perf/PerfConsumer.cc
+++ b/pulsar-client-cpp/perf/PerfConsumer.cc
@@ -301,7 +301,7 @@ int main(int argc, char** argv) {
"Number of listener threads") //
("pool-connections", po::value<bool>(&args.poolConnections)->default_value(false),
- "whether pool connections used") //
+ "whether pool connections used") //
("encryption-key-name,k", po::value<std::string>(&args.encKeyName)->default_value(""),
"The private key name to decrypt payload") //
diff --git a/pulsar-client-cpp/perf/PerfProducer.cc b/pulsar-client-cpp/perf/PerfProducer.cc
index ffc365dde7f..6e71ce78b1c 100644
--- a/pulsar-client-cpp/perf/PerfProducer.cc
+++ b/pulsar-client-cpp/perf/PerfProducer.cc
@@ -279,9 +279,8 @@ int main(int argc, char** argv) {
po::value<long>(&args.batchingMaxPublishDelayMs)->default_value(3000),
"Use only is batch-size > 1, Default is 3 seconds") //
- ("pool-connections",
- po::value<bool>(&args.poolConnections)->default_value(false),
- "whether pool connections used") //
+ ("pool-connections", po::value<bool>(&args.poolConnections)->default_value(false),
+ "whether pool connections used") //
("encryption-key-name,k", po::value<std::string>(&args.encKeyName)->default_value(""),
"The public key name to encrypt payload") // |
|
@BewareMyPower done, PTAL |
BewareMyPower
approved these changes
Dec 16, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@sijie @BewareMyPower PTAL |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
make pool connections configurable in c++ performance test.