[build] Use absolute path to locate license and checkstyle plugin config #8918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-fix-submodule-compilation
branch
from
6c0a619
to
f49d954
Compare
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 11, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@lhotari I pushed a change to make sql integration become more stable. otherwise, CI will not pass. |
Fixes apache#8911, compiling a sub module individually in the sub module directory - use proposed solution of https://stackoverflow.com/a/37965143 to set a property "pulsar.basedir" which contains the absolute path to the root directory - all other solutions don't seem to work universally in all projects, for example "project.parent.basedir" isn't available in the root project and not all projects necessarily have the root project as their parent project. - when running "license:check" or "checkstyle:checkstyle" directly, it is necessary to add "initialize" phase to the command line, for example: "mvn initialize license:check" or "mvn initialize checkstyle:checkstyle" - maven isn't intended to be used for calling individual tasks, it's recommended to use phases such as "mvn verify"
lhotari
force-pushed
the
lh-fix-submodule-compilation
branch
from
9315079
to
6e67cb3
Compare
eolivelli
approved these changes
Dec 12, 2020
|
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #8911, compiling a sub module individually in the sub module directory
Previously, the maven build failed if executed in other than the root directory if the license or checkstyle checks were run since
those plugins weren't able to find their configuration.
Modifications
use proposed solution of https://stackoverflow.com/a/37965143
to set a property
pulsar.basedirwhich contains the absolute pathto the root directory
for example
project.parent.basedirisn't available in theroot project and not all projects necessarily have the root project
as their parent project.
when running
license:checkorcheckstyle:checkstyledirectly,it is necessary to add
initializephase to the command line,since the
pulsar.basedirproperty gets set in theinitializephase.for example:
mvn initialize license:checkormvn initialize checkstyle:checkstyleas
mvn verifyinstead of listing plugin goals on the command line.