Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor if a cursor moves its mark-delete position #8930

Merged
merged 19 commits into from
Jan 6, 2021
Merged

Monitor if a cursor moves its mark-delete position #8930

merged 19 commits into from
Jan 6, 2021

Conversation

sijie
Copy link
Member

@sijie sijie commented Dec 11, 2020

Motivation

msgBacklog or storageSize doesn't provide a clear idea
if mark-delete position is advanced or not. Add a new metric
in SubscriptionStat to monitor if its mark-delete position
is advanced or not.

@sijie
Monitor if a cursor moves its mark-delete position
a5dbffc 
*Motivation*

`msgBacklog` or `storageSize` doesn't provide a clear idea
if `mark-delete` position is advanced or not. Add a new metric
in SubscriptionStat to monitor if its mark-delete position
is advanced or not.
@sijie sijie added this to the 2.8.0 milestone Dec 11, 2020
@sijie sijie self-assigned this Dec 11, 2020
eolivelli
eolivelli approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wolfstudy
Copy link
Member 

Error:  src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:[237] (javadoc) JavadocStyle: First sentence should end with a period.
Error:  src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:[242] (sizes) LineLength: Line is longer than 120 characters (found 129).
Error:  src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:[270] (sizes) LineLength: Line is longer than 120 characters (found 132).

@wolfstudy
fix ci error
537ec26 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@jiazhai
Copy link
Member

jiazhai commented Dec 13, 2020

/pulsarbot run-failure-checks

@sijie
Copy link
Member Author

sijie commented Dec 14, 2020

/pulsarbot run-failure-checks

1 similar comment
@wolfstudy
Copy link
Member

/pulsarbot run-failure-checks

@wolfstudy
Copy link
Member 

Error:  Failures: 
Error:  org.apache.pulsar.broker.service.PersistentMessageFinderTest.testMessageExpiryWithNonRecoverableException(org.apache.pulsar.broker.service.PersistentMessageFinderTest)
[INFO]   Run 1: PASS
Error:    Run 2: PersistentMessageFinderTest.testMessageExpiryWithNonRecoverableException:378 expected [3] but found [8]
[INFO] 
Error:  org.apache.pulsar.broker.service.PersistentTopicE2ETest.testMessageExpiryWithTopicMessageTTL(org.apache.pulsar.broker.service.PersistentTopicE2ETest)
[INFO]   Run 1: PASS
Error:    Run 2: PersistentTopicE2ETest.testMessageExpiryWithTopicMessageTTL:1000 expected [500] but found [409]
[INFO] 
[INFO] 
Error:  Tests run: 551, Failures: 2, Errors: 0, Skipped: 0

@zymap
Copy link
Member

zymap commented Dec 16, 2020

/pulsarbot run-failure-checks

@sijie
Copy link
Member Author

sijie commented Dec 18, 2020

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor

Don't merge this PR, CI with name Broker Group 2 is missed in the CI tests list.

@codelipenghui
Copy link
Contributor 

Error:  Tests run: 4, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 20.431 s <<< FAILURE! - in org.apache.pulsar.broker.service.PersistentMessageFinderTest
Error:  testMessageExpiryWithNonRecoverableException(org.apache.pulsar.broker.service.PersistentMessageFinderTest)  Time elapsed: 9.146 s  <<< FAILURE!
java.lang.AssertionError: expected [3] but found [8]

@codelipenghui
Copy link
Contributor 

Error:  Failures: 
Error:  org.apache.pulsar.broker.service.PersistentMessageFinderTest.testMessageExpiryWithNonRecoverableException(org.apache.pulsar.broker.service.PersistentMessageFinderTest)
[INFO]   Run 1: PASS
Error:    Run 2: PersistentMessageFinderTest.testMessageExpiryWithNonRecoverableException:379 expected [3] but found [8]

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@sijie
Copy link
Member Author

sijie commented Jan 4, 2021

@codelipenghui fixed the failed test

@sijie
Copy link
Member Author

sijie commented Jan 4, 2021

/pulsarbot run-failure-checks

@sijie
Copy link
Member Author

sijie commented Jan 5, 2021

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 2fd878a into apache:master Jan 6, 2021
codelipenghui pushed a commit that referenced this pull request Jan 6, 2021
@sijie @codelipenghui
Monitor if a cursor moves its mark-delete position (#8930)
11e974f 
Motivation

msgBacklog or storageSize doesn't provide a clear idea
if mark-delete position is advanced or not. Add a new metric
in SubscriptionStat to monitor if its mark-delete position
is advanced or not.

(cherry picked from commit 2fd878a)
@sijie sijie deleted the capture_more_events branch January 6, 2021 06:19
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jan 7, 2021
codelipenghui pushed a commit that referenced this pull request Jan 7, 2021
@sijie @codelipenghui
Monitor if a cursor moves its mark-delete position (#8930)
4ed43c9 
Motivation

msgBacklog or storageSize doesn't provide a clear idea
if mark-delete position is advanced or not. Add a new metric
in SubscriptionStat to monitor if its mark-delete position
is advanced or not.

(cherry picked from commit 2fd878a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@sijie sijie

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.6.3 release/2.7.1
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sijie @wolfstudy @jiazhai @zymap @codelipenghui @eolivelli