[ISSUE 8832] Avro custom schema not working in consumer #8939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
eolivelli
requested changes
Dec 13, 2020
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/BrokerClientIntegrationTest.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Lgtm
@codelipenghui please consider a cherry pick to 2.6 and 2.7
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 13, 2020
codelipenghui
approved these changes
Dec 14, 2020
|
@congbobo184 Could you please help take a loot at this PR? |
|
remove tag release 2.6.3 since it depends on #8464. There many conflicts with branch-2.6. |
codelipenghui
added
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8832
Modifications
Make AvroSchema's clone method consider custom reader and writer.