Fix subscription dispatch rate does not work after the topic unload without dispatch rate limit. #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout dispatch rate limit.
codelipenghui
added
component/topic-policy
type/bug
codelipenghui
requested review from
hangc0276,
sijie,
merlimat and
jiazhai
and removed request for
hangc0276 and
sijie
sijie
approved these changes
Dec 14, 2020
hangc0276
approved these changes
Dec 14, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
added a commit
that referenced
this pull request
Dec 21, 2020
…ithout dispatch rate limit. (#8947) ### Motivation Fix subscription dispatch rate does not work after the topic unload without dispatch rate limit. Currently, if the subscription dispatch rate is present then update the rate limit, the subscription can be affected by the new policy. But if the subscription dispatch rate is absent, update the rate limit, the subscription cannot be affected. ### Verifying this change New unitest added. (cherry picked from commit 37e02fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix subscription dispatch rate does not work after the topic unload without dispatch rate limit.
Currently, if the subscription dispatch rate is present then update the rate limit, the subscription can be affected by the new policy. But if the subscription dispatch rate is absent, update the rate limit, the subscription cannot be affected.
Verifying this change
New unitest added.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation