Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer support update stats with specified stats #8951

Merged
merged 2 commits into from
Dec 15, 2020
Merged

consumer support update stats with specified stats #8951

merged 2 commits into from
Dec 15, 2020

Conversation

dockerzhang
Copy link
Contributor

@dockerzhang dockerzhang commented Dec 14, 2020 •
edited
Loading

Fixes #8949

Motivation

reuse pulsar metric for KoP

Modifications

expose updateStats with ConsumerStats param, which could update stats specified stats.

Verifying this change

  • [√] Make sure that the change passes the CI checks.

@dockerzhang dockerzhang mentioned this pull request Dec 14, 2020
Merged
@sijie sijie added this to the 2.8.0 milestone Dec 14, 2020
@sijie
Copy link
Member

sijie commented Dec 14, 2020

@BewareMyPower Can you review this pull request?

@dockerzhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@dockerzhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@BewareMyPower
Copy link
Contributor

/pulsarbot run-failure-checks

@sijie sijie merged commit fcbc7eb into apache:master Dec 15, 2020
codelipenghui pushed a commit that referenced this pull request Dec 21, 2020
@dockerzhang @codelipenghui
consumer support update stats with specified stats (#8951)
70fec14 


Fixes #8949 

### Motivation
reuse pulsar metric for KoP

### Modifications

expose updateStats with ConsumerStats param, which could update stats specified stats.

### Verifying this change

- [√] Make sure that the change passes the CI checks.

(cherry picked from commit fcbc7eb)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@dockerzhang dockerzhang

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

consumer support update stats with specified stats
4 participants
@dockerzhang @sijie @BewareMyPower @codelipenghui