Make function supports to use package command #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Master Issue: apache#8676 *Motivation* We have a new package management service which can manage all the packages. We can use that in the Pulsar Function which will make the function packages are easier to manage. *Modifications* - Support new package type url
zymap
changed the title
8 tasks
|
/pulsarbot run-failure-checks |
5 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
sijie
reviewed
Dec 23, 2020
| } | ||
| } | ||
|
|
||
| return Arrays.asList( |
There was a problem hiding this comment.
Don't we need authentication and authorization plugin for downloading the packages?
There was a problem hiding this comment.
Yes. We need. Already add auth plugin at line 879.
sijie
approved these changes
Dec 29, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #8676
Motivation
We have a new package management service which can manage all
the packages. We can use that in the Pulsar Function will make the
function packages are easier to manage.
I reuse the 'packageUrl' for downloading the package from the packages
management service. So user can use the package name as the 'packageUrl'
to download it.
Modifications