Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespaces isolation policy updates take effect on time #8976

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Dec 16, 2020

Motivation

The change of namespaces isolation policy takes effect only when load-manager re-assign the bundles to brokers again.
This change tries to make the isolation policy takes effect on time.

Modifications

  • change setNamespaceIsolationPolicy method into async.
  • add parameter to enable this feature: enableNamespaceIsolationUpdateOnTime.
  • add test to cover this feature.

Verifying this change

tests passed

@jiazhai
Copy link
Member Author

jiazhai commented Dec 21, 2020

/pulsarbot run-failure-checks

@jiazhai jiazhai merged commit 3604c67 into apache:master Dec 21, 2020
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 21, 2020
codelipenghui pushed a commit that referenced this pull request Dec 21, 2020
The change of namespaces isolation policy takes effect only when load-manager re-assign the bundles to brokers again.
This change tries to make the isolation policy takes effect on time.

- change setNamespaceIsolationPolicy method into async.
- add parameter to enable this feature: enableNamespaceIsolationUpdateOnTime.
- add test to cover this feature.

tests passed

(cherry picked from commit 3604c67)
@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label Feb 25, 2021
BewareMyPower added a commit to BewareMyPower/pulsar that referenced this pull request Apr 6, 2024
…me config

### Motivation

apache#8976 introduced an
`enableNamespaceIsolationUpdateOnTime` config, which is useless after
apache#15527. This config actually does
not make sense because it should always be true, while it's false by
default just to keep the meaningless compatibility.

### Motivation

Deprecate this config and strength the
`brokerNamespaceIsolationPoliciesUpdateOnTime` test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants