PIP-68: WaitForExclusive producer access mode #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/feature
sijie
approved these changes
Dec 18, 2020
sijie
added
area/broker
doc-required
eolivelli
reviewed
Dec 18, 2020
| // If the producer is queued waiting, we will get an immediate notification | ||
| // that we need to pass to client | ||
| if (isActive()) { | ||
| log.info("[{}] Producer is waiting in qeuue: {}", remoteAddress, producer); |
| if (requestFuture != null) { | ||
| log.info("{} Producer {} has been queued up at broker. request: {}", ctx.channel(), | ||
| success.getProducerName(), requestId); | ||
| requestFuture.markAsResponded(); |
There was a problem hiding this comment.
What happens if the PulsarClient gets closed or there is a network error?
Are we guaranteed to fail and do not wait forever?
There was a problem hiding this comment.
Yes, the marking of the future is only for timeout within a single connection. When a connection fails, everything that was in that connections is marked as failed and will trigger a retry.
merlimat
commented
Dec 18, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
|
@merlimat thanks for your great work. Would you like to add docs accordingly? Then I can help review, thanks |
Anonymitaet
removed
the
doc-required
wuzhanpeng
reviewed
Sep 15, 2021
| checkArgument(producer.getTopic() == this); | ||
|
|
||
| CompletableFuture<Optional<Long>> future = new CompletableFuture<>(); | ||
|
|
||
| incrementTopicEpochIfNeeded(producer) | ||
| .thenAccept(epoch -> { | ||
| lock.readLock().lock(); |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implemented the 2nd part of the proposal for PIP-68.
With
WaitForExclusivemode, a producer is pending until there are other producers connected and then it will be created.The change in the client logic is to make sure that we don't time out the producer creation request. The broker will send a 1st response saying that the producer creation is pending. At this point the client will disable the timeout on the original request.