Improve error handling when broker doesn't trust client certificates #8998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* When TLS throws `SSLPeerUnverifiedException`, broker doesn't log any information and just returns `null`. It makes users very hard to debug problem. *Changes* Improve the error handling when broker doesn't trust client certificates. See more details at apache#8963
sijie
added
type/enhancement
zymap
approved these changes
Dec 18, 2020
codelipenghui
approved these changes
Dec 18, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Dec 18, 2020
| @@ -94,6 +96,7 @@ public boolean hasDataFromTls() { | |||
| try { | |||
| return sslSession.getPeerCertificates(); | |||
| } catch (SSLPeerUnverifiedException e) { | |||
| log.error("Failed to verify the peer's identity", e); | |||
There was a problem hiding this comment.
Is there a way to log the remote address?
jiazhai
approved these changes
Dec 20, 2020
hangc0276
approved these changes
Dec 21, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
…8998) *Motivation* When TLS throws `SSLPeerUnverifiedException`, broker doesn't log any information and just returns `null`. It makes users very hard to debug problem. *Changes* Improve the error handling when broker doesn't trust client certificates. See more details at #8963 (cherry picked from commit a292b0a)
codelipenghui
added
cherry-picked/branch-2.6
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
…8998) *Motivation* When TLS throws `SSLPeerUnverifiedException`, broker doesn't log any information and just returns `null`. It makes users very hard to debug problem. *Changes* Improve the error handling when broker doesn't trust client certificates. See more details at #8963 (cherry picked from commit a292b0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When TLS throws
SSLPeerUnverifiedException, broker doesn't log any information and just returnsnull.It makes users very hard to debug problem.
Changes
Improve the error handling when broker doesn't trust client certificates.
See more details at #8963