Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-perf] Enable pulsar-perf to load WebSocket service URL from conf file #9000

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

massakam
Copy link
Contributor

Motivation

Currently, the command line option --proxy-url is required when running the subcommand websocket-producer of pulsar-perf.

$ ./bin/pulsar-perf websocket-producer

The following option is required: -u, --proxy-url
Usage: pulsar-perf websocket-producer [options] persistent://tenant/ns/my-topic
  Options:
    ...
  * -u, --proxy-url
       Pulsar Proxy URL, e.g., "ws://localhost:8080/"

I think it would be useful to be able to load the WebSocket service URL from the config file (such as client.conf) as well as other parameters.

Modifications

pulsar-perf loads the WebSocket service URL from the config file if --proxy-url is not specified. The priorities are as follows:

  1. --proxy-url option
  2. webSocketServiceUrl in the config file
  3. webServiceUrl in the config file
  4. serviceUrl in the config file

@massakam massakam added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/cli labels Dec 18, 2020
@massakam massakam added this to the 2.8.0 milestone Dec 18, 2020
@massakam massakam self-assigned this Dec 18, 2020
@jiazhai jiazhai merged commit b43e83c into apache:master Dec 20, 2020
@massakam massakam deleted the pulsar-perf-ws branch December 21, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants