Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Fix transaction messages order error and deduplication error #9024

Merged
merged 6 commits into from
Dec 23, 2020

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Dec 22, 2020

Motivation

Currently, the transaction messages would be produced in the wrong order, and the deduplication check is not work well.

Modifications

Describe the modifications you've done.

Verifying this change

This change added tests and can be verified as follows:

  • org.apache.pulsar.client.impl.TransactionEndToEndTest#produceTxnMessageOrderTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

@gaoran10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit a5c9c15 into apache:master Dec 23, 2020
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 23, 2020
codelipenghui pushed a commit that referenced this pull request Dec 23, 2020
…error (#9024)

### Motivation

Currently, the transaction messages would be produced in the wrong order, and the deduplication check is not work well.

### Modifications

*Describe the modifications you've done.*

### Verifying this change

This change added tests and can be verified as follows:

- *org.apache.pulsar.client.impl.TransactionEndToEndTest#produceTxnMessageOrderTest*

(cherry picked from commit a5c9c15)
@gaoran10 gaoran10 deleted the txn-send-messages-order-fix branch January 12, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants