add updateRates method for kop to collect publish rate #9049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 24, 2020
codelipenghui
approved these changes
Dec 25, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
Fixes #9048 ### Motivation kop & pulsar use the same metrics collector, but kop can't collect publish rate now. streamnative/kop#284 ### Modifications add `updateRates` method for kop to collect publish rate (cherry picked from commit ccc3620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9048
Motivation
kop & pulsar use the same metrics collector, but kop can't collect publish rate now.
streamnative/kop#284
Modifications
add
updateRatesmethod for kop to collect publish rateVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)