Return correct authz and auth errors from proxy to client #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Dec 25, 2020
codelipenghui
approved these changes
Dec 25, 2020
codelipenghui
pushed a commit
that referenced
this pull request
Jan 7, 2021
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit 8574e58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the proxy will bubble up all errors to the client as a "ServiceNotReady" error which gets translated to a "LookupError" on the client side. This is not correct and precise error handling especially when the errors are auth and authz related. Potential auth and authz errors will get hidden behind "LookupError"s returned to the client and the client will retry connecting since "LookupError"s are retryable even though there is no point in retrying to connect on auth and authz errors.
Modifications
Handle the errors more accurately in the proxy