Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Netty Acceptor ThreadPool size configurable #9061

Merged
merged 3 commits into from
Dec 26, 2020
Merged

Make Netty Acceptor ThreadPool size configurable #9061

merged 3 commits into from
Dec 26, 2020

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Dec 25, 2020

Motivation

When the consumer application which serves ten thousands of consumers start, the default netty acceptor config opens slow. Make the consumer bootstrap costs long time.

Modifications

Make Netty acceptor threads can config, so people can tuning.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs / JavaDocs

@codelipenghui codelipenghui added this to the 2.8.0 milestone Dec 25, 2020
@codelipenghui
Copy link
Contributor

@shoothzj It's better to use a new branch to push PR, For more details, you can see http://pulsar.apache.org/en/contributing/

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please edit the title: "Make Netty Acceptor ThreadPool size configurable"

@shoothzj shoothzj changed the title Make netty acceptor thread can config Make Netty Acceptor ThreadPool size configurable Dec 26, 2020
@shoothzj
Copy link
Member Author

/pulsarbot run-failure-checks

@shoothzj
Copy link
Member Author

LGTM

Please edit the title: "Make Netty Acceptor ThreadPool size configurable"

Alreay Edited

@shoothzj
Copy link
Member Author

@shoothzj It's better to use a new branch to push PR, For more details, you can see http://pulsar.apache.org/en/contributing/

Ok, next time I will use a new branch to push PR.

@codelipenghui codelipenghui merged commit 2c3e33b into apache:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants