Add refresh authentication command in broker #9064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- (If this PR fixes a github issue, please add `Fixes #<xyz>`) Fixes #<xyz> (or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue) Master Issue: #<xyz> *Motivation* Describe here the context, and why you're making that change. What is the problem you're trying to solve. *Modifications* Describe the modifications you've done. *Verify this change* Please pick either of following options. - This change is a trivial rework / code cleanup without any test coverage. - This change is already covered by existing tests, such as *(please describe tests)*. - This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment* - *Extended integration test for recovery after broker failure*
jiazhai
reviewed
Dec 28, 2020
pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/AuthenticationOAuth2.java
Outdated
Show resolved
Hide resolved
jiazhai
reviewed
Dec 28, 2020
...client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/AuthenticationDataOAuth2.java
Outdated
Show resolved
Hide resolved
zymap
force-pushed
the
allow-broker-send-refresh-cmd
branch
from
8621434
to
c469ca3
Compare
zymap
changed the title
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
sijie
requested changes
Dec 30, 2020
|
@sijie sorry for the delay. This PR's goal is to address the issue that pulsar will disconnect the client if the token expired. I improve the expiration token test to include my case. |
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jan 26, 2021
sijie
approved these changes
Jan 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jan 26, 2021
* Add refresh authentication command in the broker --- **Motivation** Some authentication provider is using cached authentication data. Until redoing the 'getAuthData' then it will provide the new auth data. So I add a refresh command and do the refresh authentication data provider when received the command. **Verify this change** Existent tests can pass. (cherry picked from commit 373948e)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 26, 2021
* Add refresh authentication command in the broker --- **Motivation** Some authentication provider is using cached authentication data. Until redoing the 'getAuthData' then it will provide the new auth data. So I add a refresh command and do the refresh authentication data provider when received the command. **Verify this change** Existent tests can pass. (cherry picked from commit 373948e)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 26, 2021
* Add refresh authentication command in the broker --- **Motivation** Some authentication provider is using cached authentication data. Until redoing the 'getAuthData' then it will provide the new auth data. So I add a refresh command and do the refresh authentication data provider when received the command. **Verify this change** Existent tests can pass. (cherry picked from commit 373948e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some authentication provider is using cached authentication data. Until
redoing the 'getAuthData' then it will provide the new auth data. So
I add a refresh command and do the refresh authentication data provider
when received the command.
Verify this change